Add EMR streaming job launcher #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oavdeev
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
oavdeev
force-pushed
the
emr-streaming-launcher
branch
from
1f87c16 to
feff127
Compare
|
/kind feature |
oavdeev
force-pushed
the
emr-streaming-launcher
branch
from
feff127 to
6cc2565
Compare
oavdeev
commented
Oct 19, 2020
| @@ -99,16 +102,19 @@ def _source_to_argument(source: DataSource): | |||
| "date_partition_column": source.date_partition_column, | |||
| } | |||
|
|
|||
| kind, option_field = _SOURCES[type(source)] | |||
There was a problem hiding this comment.
option_field here was unused anyway after #1049
woop
reviewed
Oct 19, 2020
Signed-off-by: Oleg Avdeev <[email protected]>
oavdeev
force-pushed
the
emr-streaming-launcher
branch
from
6cc2565 to
167c522
Compare
|
/retest |
|
/test test-end-to-end-auth |
pyalex
approved these changes
Oct 19, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oavdeev, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/test test-end-to-end-redis-cluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add streaming ingestion job support to the EMR launcher and the launcher interface
Does this PR introduce a user-facing change?: